Attention is currently required from: Martin L Roth, Jon Murphy, Arthur Heymans, Angel Pons, Tim Van Patten, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74736 )
Change subject: RFC: util/sconfig: Add include keyword ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74736/comment/7020e323_2bcf4625 PS1, Line 9: Include
Instead of adding a new keyword, how about we just make sconfig check for a `chip. […]
Definitely they are viable alternatives. Couple of questions: @Raul: If I understand your option correctly, sconfig will include that header file and we have to go and add that header file in every mainboard to keep sconfig happy. Please correct me if I am wrong.
@Arthur: This is me trying to understand. Why was this approach not being done for all the header files included in static.c. This might make it inconsistent regarding how header files get included in static.c. Also if there is a requirement to include another header outside mainboard, can we have another build target. Atleast my read from here says no - https://www.gnu.org/software/make/manual/html_node/Multiple-Rules.html
-
Karthik Ramasubramanian (Code Review)