Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47498 )
Change subject: mb/prodrive: Disable power of KeyM slot on S5 ......................................................................
mb/prodrive: Disable power of KeyM slot on S5
Manually disable power to KeyM slot on S5 and enable it in bootblock on S0. As GPP_K7 is in the VCCPGPPHK power well it's keept powered even in S5 and doesn't reset its value.
Change-Id: I3504eed5a9f5b194fcd8b5432a8472886eec8307 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/prodrive/hermes/variants/baseboard/gpio.c 2 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/47498/1
diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index 22534c9..9dc4872 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -74,7 +74,7 @@ uint8_t value = 1; const char *method;
- /* Disable USB power on S0->S5 transition */ + /* Disable USB power on S0->S5 transition depending on EEPROM board settings */ if (check_board_settings_signature()) { read_write_config(&value, offsetof(struct eeprom_layout, BoardSettings) + offsetof(struct eeprom_board_settings, usb_powered_in_s5), @@ -100,8 +100,12 @@ acpigen_write_integer(GPP_G3); acpigen_write_name(method); acpigen_write_integer(GPP_G4); - acpigen_pop_len();
+ /* Always disable EN_3V3_KEYM_PCH on S5 */ + acpigen_write_name("\_SB.PCI0.CTXS"); + acpigen_write_integer(GPP_K7); + + acpigen_pop_len(); acpigen_pop_len();
} diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/gpio.c b/src/mainboard/prodrive/hermes/variants/baseboard/gpio.c index 9c01d24..4f35188 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/gpio.c +++ b/src/mainboard/prodrive/hermes/variants/baseboard/gpio.c @@ -373,6 +373,9 @@ PAD_CFG_GPO(GPP_K1, 1, DEEP), /* PERST_CPU_SLOTS_n */ PAD_CFG_GPO(GPP_K2, 1, DEEP), /* PERST_CNVI_SLOTS_n */
+ /* Power KeyM slot */ + PAD_CFG_GPO(GPP_K7, 1, DEEP), /* EN_3V3_KEYM_PCH */ + /* SMB */ PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* PCH_SMB_CLK */ PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* PCH_SMB_DATA */
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47498
to look at the new patch set (#2).
Change subject: mb/prodrive/acpi: Add power resource for Key M slot ......................................................................
mb/prodrive/acpi: Add power resource for Key M slot
Add methods to enable/disable the power to Key M slot.
Change-Id: I3504eed5a9f5b194fcd8b5432a8472886eec8307 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/prodrive/hermes/variants/baseboard/gpio.c 3 files changed, 34 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/47498/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47498
to look at the new patch set (#3).
Change subject: mb/prodrive/acpi: Add power resource for Key M slot ......................................................................
mb/prodrive/acpi: Add power resource for Key M slot
Add methods to enable/disable the power to Key M slot.
Change-Id: I3504eed5a9f5b194fcd8b5432a8472886eec8307 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/prodrive/hermes/variants/baseboard/gpio.c 2 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/47498/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47498 )
Change subject: mb/prodrive/acpi: Add power resource for Key M slot ......................................................................
Patch Set 3: Code-Review+1
Hello build bot (Jenkins), Christian Walter, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47498
to look at the new patch set (#4).
Change subject: mb/prodrive/acpi: Add power resource for Key M slot ......................................................................
mb/prodrive/acpi: Add power resource for Key M slot
Add methods to enable/disable the power to Key M slot.
Change-Id: I3504eed5a9f5b194fcd8b5432a8472886eec8307 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/prodrive/hermes/variants/baseboard/gpio.c 3 files changed, 54 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/47498/4
Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47498 )
Change subject: mb/prodrive/acpi: Add power resource for Key M slot ......................................................................
Abandoned
Superseded by: CB:48809
-
Angel Pons (Code Review) -
Patrick Rudolph (Code Review)