Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Documentation/security/vboot: Add device list ......................................................................
Documentation/security/vboot: Add device list
Add a list of VBOOT enabled devices to the documetation.
Change-Id: Ibb57d26c5f0cb8efd27ca9a97fd762c25b566f93 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io --- M Documentation/security/vboot/index.md 1 file changed, 96 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39200/1
diff --git a/Documentation/security/vboot/index.md b/Documentation/security/vboot/index.md index 400c2b5..75f34cc 100644 --- a/Documentation/security/vboot/index.md +++ b/Documentation/security/vboot/index.md @@ -342,3 +342,99 @@ any firmware may be placed on the device. However, accessing this screw requires opening the case and voids the system warranty! + +## VBOOT enabled devices + +### AAEON +- UP Square + +### emulation +- qemu-i440fx +- qemu-q35 + +### facebook +- monolith + +### Google +- auron +- beltino +- butterfly +- cheza +- cyan +- daisy +- dragonegg +- drallion +- eve +- fizz +- foster +- gale +- glados +- gru +- hatch +- jecht +- kahlee +- kukui +- link +- mistral +- nyan_big +- nyan_blaze +- nyan +- oak +- parrot +- peach_pit +- poppy +- rambi +- reef +- sarien +- slippy +- smaug +- storm +- stout +- trogdor +- veyron +- veyron_mickey +- veyron_rialto + +### HP +- z220_sff_workstation + +### Intel +- baskingridge +- cannonlake_rvp +- coffeelake_rvp +- emeraldlake2 +- galileo +- glkrvp +- icelake_rvp +- jasperlake_rvp +- kblrvp +- kunimitsu +- strago +- tglrvp +- wtm2 + +### Lenovo +- t400 +- t410 +- t420 +- t420s +- t520 +- x200 +- x201 +- x220 + +### OpenCellular +- elgon + +### Samsung +- lumpy +- stumpy + +### Siemens +- mc_apl2 +- mc_apl4 +- mc_apl5 +- mc_apl6 + +### Supermicro +- x11-lga1151
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Documentation/security/vboot: Add device list ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39200/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39200/1//COMMIT_MSG@9 PS1, Line 9: documetation documentation
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Documentation/security/vboot: Add device list ......................................................................
Patch Set 1: Code-Review+1
I mean, by all means - but we need to make sure that the list is kept up to date now...
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Documentation/security/vboot: Add device list ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1: Code-Review+1
I mean, by all means - but we need to make sure that the list is kept up to date now...
It could be autogenerated, but the coreboot repo needs to be hooked into the docker container for that.
https://review.coreboot.org/c/coreboot/+/39200/1/Documentation/security/vboo... File Documentation/security/vboot/index.md:
https://review.coreboot.org/c/coreboot/+/39200/1/Documentation/security/vboo... PS1, Line 346: VBOOT It doesn't take variants into account and thus some devices are missing. It should use MAINBOARD_PART_NUMBER as it's a better name.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Documentation/security/vboot: Add device list ......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
Patch Set 1: Code-Review+1
I mean, by all means - but we need to make sure that the list is kept up to date now...
It could be autogenerated, but the coreboot repo needs to be hooked into the docker container for that.
I suppose we could add a lint test that fails if a board with the right Kconfig flag isn't mentioned there, too?
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39200
to look at the new patch set (#2).
Change subject: Documentation/security/vboot: Add device list ......................................................................
Documentation/security/vboot: Add device list
Add a script generated list of VBOOT enabled devices to the documentation.
Change-Id: Ibb57d26c5f0cb8efd27ca9a97fd762c25b566f93 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io --- A Documentation/security/vboot/generate_vboot_list.sh M Documentation/security/vboot/index.md A Documentation/security/vboot/list_vboot.md 3 files changed, 264 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39200/2
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Documentation/security/vboot: Add device list ......................................................................
Patch Set 2:
Patch Set 1:
Patch Set 1:
(1 comment)
Patch Set 1: Code-Review+1
I mean, by all means - but we need to make sure that the list is kept up to date now...
It could be autogenerated, but the coreboot repo needs to be hooked into the docker container for that.
I suppose we could add a lint test that fails if a board with the right Kconfig flag isn't mentioned there, too?
I wrote a script to generate the VBOOT device list. Should I add a git commit hook to check, if it has changed?
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Documentation/security/vboot: Add device list ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... File Documentation/security/vboot/generate_vboot_list.sh:
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... PS2, Line 1: #!/usr/bin/env bash move to /util this could be mentioned in releases/checklist.md
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... File Documentation/security/vboot/index.md:
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... PS2, Line 15: list_vboot this file needs to be referenced by a toctree, that is:
* [List of supported Devices](list_vboot.md)
or
- [List of supported Devices](list_vboot.md)
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39200
to look at the new patch set (#3).
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Doc/security/vboot: Add a script generated device list
Add a script generated list of vboot enabled devices to the documentation.
TODO: - Add a commit hook to verify if the list has changed
Change-Id: Ibb57d26c5f0cb8efd27ca9a97fd762c25b566f93 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io --- M Documentation/security/vboot/index.md A Documentation/security/vboot/list_vboot.md A util/vboot_list/description.md A util/vboot_list/vboot_list.sh 4 files changed, 266 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39200/3
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... File Documentation/security/vboot/generate_vboot_list.sh:
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... PS2, Line 1: #!/usr/bin/env bash
move to /util
Done
this could be mentioned in releases/checklist.md
How/where exactly should I mention it?
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39200/3/util/vboot_list/vboot_list.... File util/vboot_list/vboot_list.sh:
https://review.coreboot.org/c/coreboot/+/39200/3/util/vboot_list/vboot_list.... PS3, Line 19: sed -n '/config VENDOR/{n;s/^[\t[:space:]]+bool "(.*)"/\1/;p;}' $VENDORDIR/Kconfig.name line over 96 characters
https://review.coreboot.org/c/coreboot/+/39200/3/util/vboot_list/vboot_list.... PS3, Line 26: sed -n '/config BOARD/{n;s/^[\t[:space:]]+bool "(->\s+)?(.*)"/\2/;p;}' $BOARDDIR/Kconfig.name line over 96 characters
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39200
to look at the new patch set (#4).
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Doc/security/vboot: Add a script generated device list
Add a script generated list of vboot enabled devices to the documentation.
TODO: - Add a commit hook to verify if the list has changed
Change-Id: Ibb57d26c5f0cb8efd27ca9a97fd762c25b566f93 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io --- M Documentation/security/vboot/index.md A Documentation/security/vboot/list_vboot.md A util/vboot_list/description.md A util/vboot_list/vboot_list.sh 4 files changed, 268 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39200/4
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... File Documentation/security/vboot/index.md:
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... PS2, Line 15: list_vboot
this file needs to be referenced by a toctree, that is: […]
Done
https://review.coreboot.org/c/coreboot/+/39200/3/util/vboot_list/vboot_list.... File util/vboot_list/vboot_list.sh:
https://review.coreboot.org/c/coreboot/+/39200/3/util/vboot_list/vboot_list.... PS3, Line 19: sed -n '/config VENDOR/{n;s/^[\t[:space:]]+bool "(.*)"/\1/;p;}' $VENDORDIR/Kconfig.name
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/39200/3/util/vboot_list/vboot_list.... PS3, Line 26: sed -n '/config BOARD/{n;s/^[\t[:space:]]+bool "(->\s+)?(.*)"/\2/;p;}' $BOARDDIR/Kconfig.name
line over 96 characters
Done
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39200/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39200/1//COMMIT_MSG@9 PS1, Line 9: documetation
documentation
Done
https://review.coreboot.org/c/coreboot/+/39200/1/Documentation/security/vboo... File Documentation/security/vboot/index.md:
https://review.coreboot.org/c/coreboot/+/39200/1/Documentation/security/vboo... PS1, Line 346: VBOOT
It doesn't take variants into account and thus some devices are missing. […]
by Design. The list would explode, if we include each variant.
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39200
to look at the new patch set (#5).
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Doc/security/vboot: Add a script generated device list
Add a script generated list of vboot enabled devices to the documentation. Add a entry to the release checklist.
Change-Id: Ibb57d26c5f0cb8efd27ca9a97fd762c25b566f93 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io --- M Documentation/releases/checklist.md M Documentation/security/vboot/index.md A Documentation/security/vboot/list_vboot.md A util/vboot_list/description.md A util/vboot_list/vboot_list.sh 5 files changed, 283 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39200/5
Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... File Documentation/security/vboot/generate_vboot_list.sh:
https://review.coreboot.org/c/coreboot/+/39200/2/Documentation/security/vboo... PS2, Line 1: #!/usr/bin/env bash
move to /util […]
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Patch Set 5: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Doc/security/vboot: Add a script generated device list
Add a script generated list of vboot enabled devices to the documentation. Add a entry to the release checklist.
Change-Id: Ibb57d26c5f0cb8efd27ca9a97fd762c25b566f93 Signed-off-by: Marcello Sylvester Bauer sylv@sylv.io Reviewed-on: https://review.coreboot.org/c/coreboot/+/39200 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Documentation/releases/checklist.md M Documentation/security/vboot/index.md A Documentation/security/vboot/list_vboot.md A util/vboot_list/description.md A util/vboot_list/vboot_list.sh 5 files changed, 283 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Patrick Rudolph: Looks good to me, but someone else must approve
diff --git a/Documentation/releases/checklist.md b/Documentation/releases/checklist.md index 706d08e..ea05c20 100644 --- a/Documentation/releases/checklist.md +++ b/Documentation/releases/checklist.md @@ -68,6 +68,7 @@ - [ ] Test the commit selected for release. - [ ] Update release notes with actual commit id, push to repo. - [ ] Run release script. +- [ ] Run vboot_list script. - [ ] Test the release from the actual release tarballs. - [ ] Push signed Tag to repo. - [ ] Announce that the release tag is done on IRC. diff --git a/Documentation/security/vboot/index.md b/Documentation/security/vboot/index.md index 400c2b5..997db8b 100644 --- a/Documentation/security/vboot/index.md +++ b/Documentation/security/vboot/index.md @@ -12,6 +12,8 @@
Google's vboot verifies the firmware and places measurements within the TPM.
+- [List of supported Devices](list_vboot.md) + ***
## Root of Trust diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md new file mode 100644 index 0000000..1bef823 --- /dev/null +++ b/Documentation/security/vboot/list_vboot.md @@ -0,0 +1,223 @@ +# VBOOT enabled devices + +## Emulation +- QEMU x86 i440fx/piix4 (aka qemu -M pc) +- QEMU x86 q35/ich9 (aka qemu -M q35, since v1.4) + +## Facebook +- Facebook Monolith + +## Google +- Auron_Paine (Acer C740 Chromebook) +- Auron_Yuna (Acer Chromebook 15 (C910/CB5-531)) +- Buddy (Acer Chromebase 24) +- Gandof (Toshiba Chromebook 2 (2015)) +- Lulu (Dell Chromebook 13 7310) +- Samus (Google Chromebook Pixel (2015)) +- Mccloud (Acer Chromebox CXI) +- Monroe (LG Chromebase 22CV241 & 22CB25S) +- Panther (ASUS Chromebox CN60) +- Tricky (Dell Chromebox 3010) +- Zako (HP Chromebox G1) +- Butterfly (HP Pavilion Chromebook 14) +- Cheza +- Banon (Acer Chromebook 15 (CB3-532)) +- Celes (Samsung Chromebook 3) +- Cyan (Acer Chromebook R11 (C738T)) +- Edgar (Acer Chromebook 14 (CB3-431)) +- Kefka (Dell Chromebook 11 3180/3189) +- Reks (Lenovo N22/N42 Chromebook) +- Relm +- Setzer (HP Chromebook 11 G5) +- Terra (ASUS Chromebook C202SA/C300SA/C301SA) +- Ultima (Lenovo Yoga 11e G3) +- Wizpig +- Daisy (Samsung Chromebook (2012)) +- DragonEgg +- Drallion +- Eve (Google Pixelbook) +- Fizz +- Karma +- Endeavour +- Foster +- Gale (Google WiFi) +- Asuka (Dell Chromebook 13 3380) +- Caroline (Samsung Chromebook Pro) +- Cave (Asus Chromebook Flip C302SA) +- Chell (HP Chromebook 13 G1) +- Glados Skylake Reference Board +- Lars (Acer Chromebook 14 for Work (CP5-471)) +- Sentry (Lenovo Thinkpad 13 Chromebook) +- Kevin (Samsung Chromebook Plus) +- Gru +- Bob (Asus Chromebook Flip C101PA) +- Scarlet +- Nefario +- Rainier +- Akemi +- Dratini +- Hatch +- Jinlon +- Kohaku +- Kindred +- Helios +- Mushu +- Palkia +- Nightfury +- Puff +- Helios_Diskswap +- Stryke +- Guado (ASUS Chromebox CN62) +- Jecht +- Rikku (Acer Chromebox CXI2) +- Tidus (Lenovo ThinkCentre Chromebox) +- Aleena +- Careena +- Grunt +- Liara +- Nuwani +- Treeya +- Kukui +- Krane +- Kodama +- Kakadu +- Flapjack +- Jacuzzi +- Juniper +- Kappa +- Damu +- Link (Google Chromebook Pixel (2013)) +- Mistral +- Nyan +- Nyan Big (Acer Chromebook 13 (CB5-311)) +- Nyan Blaze (HP Chromebook 14 G3) +- Oak +- Elm (Acer Chromebook R13) +- Hana (Lenovo N23 Yoga Chromebook) +- Parrot (Acer C7/C710 Chromebook) +- Peach Pit (Samsung Chromebook 2 11") +- Atlas +- Poppy +- Nami +- Nautilus +- Nocturne +- Rammus +- Soraka +- Banjo (Acer Chromebook 15 (CB3-531)) +- Candy (Dell Chromebook 11 3120) +- Clapper (Lenovo N20 Chromebook) +- Enguarde +- Glimmer (Lenovo ThinkPad 11e Chromebook) +- Gnawty (Acer Chromebook 11 (CB3-111/131,C730/C730E/C735)) +- Heli (Haier Chromebook G2) +- Kip (HP Chromebook 11 G3 / G4 / G4 EE) +- Ninja (AOpen Chromebox Commercial) +- Orco (Lenovo 100S Chromebook) +- Quawks (ASUS Chromebook C300) +- Squawks (ASUS Chromebook C200) +- Rambi +- Sumo (AOpen Chromebase Commercial) +- Swanky (Toshiba Chromebook 2) +- Winky (Samsung Chromebook 2 (XE500C12)) +- Reef/Electro (Acer Chromebook Spin 11 R751T) +- Pyro (Lenovo Thinkpad (Yoga) 11e Chromebook) +- Sand (Acer Chromebook 15 CB515-1HT/1H) +- Snappy (HP Chromebook x360 11 G1 EE) +- Nasher +- Coral +- Arcada +- Sarien +- Falco (HP Chromebook 14) +- Leon (Toshiba Chromebook) +- Peppy (Acer C720/C720P Chromebook) +- Wolf (Dell Chromebook 11) +- Smaug (Google Pixel C) +- Storm (OnHub Router TGR1900) +- Stout (Lenovo Thinkpad X131e Chromebook) +- Trogdor +- Veyron_Jaq (Haier Chromebook 11) +- Veyron_Jerry (Hisense Chromebook 11) +- Veyron_Mighty (Haier Chromebook 11(edu)) +- Veyron_Minnie (ASUS Chromebook Flip C100) +- Veyron_Speedy (ASUS C201 Chromebook) +- Veyron_Mickey (Asus Chromebit CS10) +- Veyron_Rialto + +## HP +- Z220 SFF Workstation + +## Intel +- Basking Ridge CRB +- Cannonlake U LPDDR4 RVP +- Cannonlake Y LPDDR4 RVP +- Coffeelake U SO-DIMM DDR4 RVP +- Coffeelake H SO-DIMM DDR4 RVP11 +- Whiskeylake U DDR4 RVP +- Coffeelake S U-DIMM DDR4 RVP8 +- Cometlake U DDR4 RVP +- Emerald Lake 2 CRB +- Galileo +- Glkrvp +- Icelake U DDR4/LPDDR4 RVP +- Icelake Y LPDDR4 RVP +- Jasperlake DDR4/LPDDR4 RVP +- Jasperlake DDR4/LPDDR4 RVP with Chrome EC +- Kabylake LPDDR3 RVP3 +- Kabylake DDR3L RVP7 +- Kabylake DDR4 RVP8 +- Kabylake DDR4 RVP11 +- Kunimitsu +- Strago +- Tigerlake UP3 RVP +- Tigerlake UP4 RVP +- Whitetip Mountain 2 CRB + +## Lenovo +- ThinkPad T400 +- ThinkPad T500 +- ThinkPad R400 +- ThinkPad R500 +- ThinkPad W500 +- ThinkPad T410 +- ThinkPad T420 +- ThinkPad T420s +- ThinkPad T430 +- ThinkPad T430s +- ThinkPad T431s +- ThinkPad T440p +- ThinkPad T520 +- ThinkPad W520 +- ThinkPad T530 +- ThinkPad W530 +- ThinkPad X131e +- ThinkPad X1 carbon gen 1 +- ThinkPad X200 / X200s / X200t +- ThinkPad X301 +- ThinkPad X201 / X201i / X201s / X201t +- ThinkPad X220 +- ThinkPad X220i +- ThinkPad X1 +- ThinkPad X230 +- ThinkPad X230t + +## OpenCellular +- Elgon (GBCv2) + +## SAMSUNG +- Lumpy +- Stumpy + +## Siemens +- MC APL1 +- MC APL2 +- MC APL3 +- MC APL4 +- MC APL5 +- MC APL6 + +## Supermicro +- X11SSH-TF +- X11SSM-F + +## UP +- Squared diff --git a/util/vboot_list/description.md b/util/vboot_list/description.md new file mode 100644 index 0000000..b994557 --- /dev/null +++ b/util/vboot_list/description.md @@ -0,0 +1,2 @@ +Tools to generate a list of vboot enabled devices to the documentation +`Bash` diff --git a/util/vboot_list/vboot_list.sh b/util/vboot_list/vboot_list.sh new file mode 100755 index 0000000..f3e8975 --- /dev/null +++ b/util/vboot_list/vboot_list.sh @@ -0,0 +1,55 @@ +#!/usr/bin/env bash + +TOP="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../.. >/dev/null 2>&1 && pwd )" +MAINBOARDS="src/mainboard" +OUTPUT_FILE=${1:-$TOP/Documentation/security/vboot/list_vboot.md} + +function has_vboot +{ + local DIR=$1 + + grep -rq "config VBOOT" $DIR + return $? +} + +function get_vendor_name +{ + local VENDORDIR=$1 + + sed -n '/config VENDOR/{n;s/^[\t[:space:]]+bool "(.*)"/\1/;p;}' \ + $VENDORDIR/Kconfig.name +} + +function get_board_name +{ + local BOARDDIR=$1 + + sed -n '/config BOARD/{n;s/^[\t[:space:]]+bool "(->\s+)?(.*)"/\2/;p;}' \ + $BOARDDIR/Kconfig.name +} + +function list_vboot_boards +{ + local VENDORDIR=$1 + for BOARD in $(ls -d $VENDORDIR/*/) + do + has_vboot $BOARD || continue + get_board_name $BOARD + done +} + +function generate_vboot_list +{ +for VENDOR in $(ls -d $TOP/$MAINBOARDS/*/) +do + has_vboot $VENDOR || continue + echo -e "\n## $(get_vendor_name $VENDOR)" + IFS=$'\n' + for BOARD in $(list_vboot_boards $VENDOR) + do + echo "- $BOARD" + done +done +} + +(echo "# VBOOT enabled devices"; generate_vboot_list) > $OUTPUT_FILE
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39200 )
Change subject: Doc/security/vboot: Add a script generated device list ......................................................................
Patch Set 6:
I was just made aware of this file, what's the general idea here? Is everyone who's adding a new mainboard or changing the name supposed to manually update this? Because that doesn't scale without some sort of automatism.
If the intention is only to update it for each release, can we document that somewhere so people don't get confused? (Does Markdown have comments that don't appear in the final output? If so, just putting a comment at the top of list_vboot.md would probably be good enough.)
-
build bot (Jenkins) (Code Review) -
Julius Werner (Code Review)
-
Marcello Sylvester Bauer (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)