Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35668 )
Change subject: intel/fsp_baytrail: Drop unnecessary lookup for PCI 0:0.0 ......................................................................
intel/fsp_baytrail: Drop unnecessary lookup for PCI 0:0.0
It is safe to assume this to be copy-paste from eg. i945 where registers of said PCI device were read.
Change-Id: I387b7fd6caf317543a6438f973d9e1d96e418de3 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/fsp_baytrail/northcluster.c 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/35668/1
diff --git a/src/soc/intel/fsp_baytrail/northcluster.c b/src/soc/intel/fsp_baytrail/northcluster.c index 416746d..797039a 100644 --- a/src/soc/intel/fsp_baytrail/northcluster.c +++ b/src/soc/intel/fsp_baytrail/northcluster.c @@ -87,15 +87,10 @@
static int get_pcie_bar(u32 *base) { - struct device *dev; u32 pciexbar_reg;
*base = 0;
- dev = pcidev_on_root(0, 0); - if (!dev) - return 0; - pciexbar_reg = iosf_bunit_read(BUNIT_MMCONF_REG);
if (!(pciexbar_reg & (1 << 0)))
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35668 )
Change subject: intel/fsp_baytrail: Drop unnecessary lookup for PCI 0:0.0 ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35668 )
Change subject: intel/fsp_baytrail: Drop unnecessary lookup for PCI 0:0.0 ......................................................................
intel/fsp_baytrail: Drop unnecessary lookup for PCI 0:0.0
It is safe to assume this to be copy-paste from eg. i945 where registers of said PCI device were read.
Change-Id: I387b7fd6caf317543a6438f973d9e1d96e418de3 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35668 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/fsp_baytrail/northcluster.c 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/fsp_baytrail/northcluster.c b/src/soc/intel/fsp_baytrail/northcluster.c index 416746d..797039a 100644 --- a/src/soc/intel/fsp_baytrail/northcluster.c +++ b/src/soc/intel/fsp_baytrail/northcluster.c @@ -87,15 +87,10 @@
static int get_pcie_bar(u32 *base) { - struct device *dev; u32 pciexbar_reg;
*base = 0;
- dev = pcidev_on_root(0, 0); - if (!dev) - return 0; - pciexbar_reg = iosf_bunit_read(BUNIT_MMCONF_REG);
if (!(pciexbar_reg & (1 << 0)))