Attention is currently required from: Caveh Jalali, Forest Mittelberg.
ChromeOS coreboot bot has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83743?usp=email )
Change subject: UPSTREAM: Revert "PPM: Enable driver by default" ......................................................................
UPSTREAM: Revert "PPM: Enable driver by default"
This reverts commit 433f78dcdf5bfc3ebba8d051aa864659b7061da7.
Reason for revert: Inconsistent behavior with coreboot
BUG=b:319124515
Original change's description:
PPM: Enable driver by default
Change the behavior of the CBI bit to disable UCSI instead of enable it. As a result, the PPM driver will be enabled by default.
BUG=b:319124515 TEST=Confirm cros_ec_ucsi runs successfully with CBI bit unset LOW_COVERAGE_REASON=Will add via b:335261254
Change-Id: I0e8f83a42cc6a5f8be3cee19dd671fbdaa0c8620 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/5646872 Code-Coverage: Zoss zoss-cl-coverage@prod.google.com Reviewed-by: Keith Short keithshort@chromium.org Commit-Queue: Abhishek Pandit-Subedi abhishekpandit@google.com Tested-by: Abhishek Pandit-Subedi abhishekpandit@google.com
BUG=b:319124515
Original-Change-Id: I250f17853c7c603d48fdb630ada99243019760d6 Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/5662648 Original-Code-Coverage: Zoss zoss-cl-coverage@prod.google.com Original-Reviewed-by: Keith Short keithshort@chromium.org Original-Auto-Submit: Abhishek Pandit-Subedi abhishekpandit@google.com Original-Commit-Queue: Abhishek Pandit-Subedi abhishekpandit@google.com Original-Tested-by: Abhishek Pandit-Subedi abhishekpandit@google.com GitOrigin-RevId: 58a4ddfe9766e3d33c79f9296d24579414f08ee4 Change-Id: I9d880d1c006446f131747ebbb26b9e7d15892f34 --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/83743/1
diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index 914f580..60bff47 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -6492,7 +6492,7 @@
union ec_common_control { struct { - uint32_t ucsi_disabled : 1; + uint32_t ucsi_enabled : 1; }; uint32_t raw_value; };