Attention is currently required from: Jon Murphy, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83745?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/hatch: Add FP enable for Dratini
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83745/comment/e4cf00a2_ed6b5e67?usp... :
PS7, Line 7: mb/google/hatch: Add FP enable for Dratini
Use `mb/google/hatch/var/dratini:`?
https://review.coreboot.org/c/coreboot/+/83745/comment/ac49013f_cdaec6fd?usp... :
PS7, Line 18: Disable test SKU, flash on Dratini, test FP.
Any log messages?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83745?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0
Gerrit-Change-Number: 83745
Gerrit-PatchSet: 7
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 09 Sep 2024 18:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No