Attention is currently required from: Furquan Shaikh, Francois Toguo Fotso, Subrata Banik, Jonathan Zhang, Daocheng Bu, Kane Chen, Patrick Rudolph, Karthik Ramasubramanian, Tim Chu.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57684 )
Change subject: soc/intel/common: Add PMC Crashlog PCI driver
......................................................................
Patch Set 9:
(2 comments)
File src/soc/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/57684/comment/0f51cad6_8bbeec2e
PS9, Line 40: crashlog record on every boot.
Do you mean "enables the PMC crashlog driver to collect crashlog records on every reset"? If the PMC […]
You can configure the PMC so that it will collect a trace of its activity during boot; so if you enable the Kconfig, it will send that message on every boot, hence every warm reboot will contain a PMC crashlog trace only.
File src/soc/intel/common/block/crashlog/pmc_crashlog.c:
https://review.coreboot.org/c/coreboot/+/57684/comment/3bab3ad0_050b75f4
PS9, Line 269:
Once crashlog records are collected, should we clear the records?
Yep, that's part of the `enable` flow, see line 292
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc27bbdf35fcd680be224ba0a0e642c94d29bca3
Gerrit-Change-Number: 57684
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 15 Apr 2022 19:29:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment