[M] Change in coreboot[master]: cpu,soc/intel: Sync ACPI CPU object implementations - coreboot-gerrit

14 Apr 2023


      Attention is currently required from: Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74396 )
Change subject: cpu,soc/intel: Sync ACPI CPU object implementations
......................................................................
Patch Set 2:
(1 comment)
File src/cpu/intel/haswell/acpi.c:
https://review.coreboot.org/c/coreboot/+/74396/comment/5f219f06_9d09a642 
PS2, Line 337: 	for (int cpu_id = 0; cpu_id < numcpus; cpu_id++) {
...
...
it's more common in coreboot to define the local variables at the beginning of the function and no […]
good point
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74396
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14e1120e74e1bd92acd782a53104fabfb266c3b5
Gerrit-Change-Number: 74396
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 14 Apr 2023 13:04:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment