Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34815 )
Change subject: mb/google/hatch: Fix Kohaku pen GPIO configuration ......................................................................
mb/google/hatch: Fix Kohaku pen GPIO configuration
Oops, I missed this in the last CL. The pin needs to be configured as owned by GPIO, so that the kernel driver can bind it with an IRQ.
BUG=b:139165490 TEST=Ensure kernel nastygram about inability to claim the IRQ is gone
Change-Id: I26c08d75d8b4e3b834db6e90868239899605fa5b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/kohaku/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/34815/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c index 53a58c9..9654388 100644 --- a/src/mainboard/google/hatch/variants/kohaku/gpio.c +++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c @@ -26,7 +26,7 @@ /* A10 : PEN_RESET_ODL */ PAD_CFG_GPO(GPP_A10, 1, DEEP), /* A16 : EMR_GARAGE_DET (notification) */ - PAD_CFG_GPI_APIC(GPP_A16, NONE, PLTRST, LEVEL, NONE), + PAD_CFG_GPI_GPIO_DRIVER(GPP_A16, NONE, PLTRST), /* A17 : PIRQA# ==> NC */ PAD_NC(GPP_A17, NONE), /* A18 : ISH_GP0 ==> NC */
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34815 )
Change subject: mb/google/hatch: Fix Kohaku pen GPIO configuration ......................................................................
Patch Set 1: Code-Review+1
Giving others a chance to review and +2 it
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34815 )
Change subject: mb/google/hatch: Fix Kohaku pen GPIO configuration ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34815 )
Change subject: mb/google/hatch: Fix Kohaku pen GPIO configuration ......................................................................
mb/google/hatch: Fix Kohaku pen GPIO configuration
Oops, I missed this in the last CL. The pin needs to be configured as owned by GPIO, so that the kernel driver can bind it with an IRQ.
BUG=b:139165490 TEST=Ensure kernel nastygram about inability to claim the IRQ is gone
Change-Id: I26c08d75d8b4e3b834db6e90868239899605fa5b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34815 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/kohaku/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c index 53a58c9..9654388 100644 --- a/src/mainboard/google/hatch/variants/kohaku/gpio.c +++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c @@ -26,7 +26,7 @@ /* A10 : PEN_RESET_ODL */ PAD_CFG_GPO(GPP_A10, 1, DEEP), /* A16 : EMR_GARAGE_DET (notification) */ - PAD_CFG_GPI_APIC(GPP_A16, NONE, PLTRST, LEVEL, NONE), + PAD_CFG_GPI_GPIO_DRIVER(GPP_A16, NONE, PLTRST), /* A17 : PIRQA# ==> NC */ PAD_NC(GPP_A17, NONE), /* A18 : ISH_GP0 ==> NC */
-
Furquan Shaikh (Code Review) -
Martin Roth (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)