Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38083 )
Change subject: HP sandy/ivy desktops: Fix Kconfig symbol names ......................................................................
HP sandy/ivy desktops: Fix Kconfig symbol names
hp/z220_sff_workstation was using BOARD_HP_COMPAQ_8200_ELITE_SFF_PC, and hp/compaq_8200_elite was using a very long name. Fix that.
Change-Id: I434cde42c7b9f30f8de77b96bc924aa298bad921 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name M src/mainboard/hp/z220_sff_workstation/Kconfig M src/mainboard/hp/z220_sff_workstation/Kconfig.name 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/38083/1
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig index 42efd4a..e3b2ebd 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig @@ -1,4 +1,4 @@ -if BOARD_HEWLETT_PACKARD_HP_COMPAQ_8200_ELITE_SFF_PC +if BOARD_HP_COMPAQ_8200_ELITE_SFF_PC
config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name index 8de7363..fad77d0 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name @@ -1,2 +1,2 @@ -config BOARD_HEWLETT_PACKARD_HP_COMPAQ_8200_ELITE_SFF_PC +config BOARD_HP_COMPAQ_8200_ELITE_SFF_PC bool "Compaq 8200 Elite SFF" diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index 649cbb1..dc288d6 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -1,4 +1,4 @@ -if BOARD_HP_COMPAQ_8200_ELITE_SFF_PC +if BOARD_HP_Z220_SFF_WORKSTATION
config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig.name b/src/mainboard/hp/z220_sff_workstation/Kconfig.name index b6cfda6..037ebc0 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig.name +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig.name @@ -1,2 +1,2 @@ -config BOARD_HP_COMPAQ_8200_ELITE_SFF_PC +config BOARD_HP_Z220_SFF_WORKSTATION bool "Z220 SFF Workstation"
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38083 )
Change subject: HP sandy/ivy desktops: Fix Kconfig symbol names ......................................................................
Patch Set 1: Code-Review+2
Note that might break scripts/CI that depend on the board name.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38083 )
Change subject: HP sandy/ivy desktops: Fix Kconfig symbol names ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38083 )
Change subject: HP sandy/ivy desktops: Fix Kconfig symbol names ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
Note that might break scripts/CI that depend on the board name.
Agreed. I believe they should be updated as well.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38083 )
Change subject: HP sandy/ivy desktops: Fix Kconfig symbol names ......................................................................
HP sandy/ivy desktops: Fix Kconfig symbol names
hp/z220_sff_workstation was using BOARD_HP_COMPAQ_8200_ELITE_SFF_PC, and hp/compaq_8200_elite was using a very long name. Fix that.
Change-Id: I434cde42c7b9f30f8de77b96bc924aa298bad921 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38083 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name M src/mainboard/hp/z220_sff_workstation/Kconfig M src/mainboard/hp/z220_sff_workstation/Kconfig.name 4 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig index 42efd4a..e3b2ebd 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig @@ -1,4 +1,4 @@ -if BOARD_HEWLETT_PACKARD_HP_COMPAQ_8200_ELITE_SFF_PC +if BOARD_HP_COMPAQ_8200_ELITE_SFF_PC
config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name index 8de7363..fad77d0 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig.name @@ -1,2 +1,2 @@ -config BOARD_HEWLETT_PACKARD_HP_COMPAQ_8200_ELITE_SFF_PC +config BOARD_HP_COMPAQ_8200_ELITE_SFF_PC bool "Compaq 8200 Elite SFF" diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index 649cbb1..dc288d6 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -1,4 +1,4 @@ -if BOARD_HP_COMPAQ_8200_ELITE_SFF_PC +if BOARD_HP_Z220_SFF_WORKSTATION
config BOARD_SPECIFIC_OPTIONS def_bool y diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig.name b/src/mainboard/hp/z220_sff_workstation/Kconfig.name index b6cfda6..037ebc0 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig.name +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig.name @@ -1,2 +1,2 @@ -config BOARD_HP_COMPAQ_8200_ELITE_SFF_PC +config BOARD_HP_Z220_SFF_WORKSTATION bool "Z220 SFF Workstation"
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Patrick Rudolph (Code Review)