Change in coreboot[master]: mb/google/dedede/var/drawcia: Re-tune override GPIO table - coreboot-gerrit

1 Mar 2021


      Attention is currently required from: Henry Sun, Evan Green, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51153 )
Change subject: mb/google/dedede/var/drawcia: Re-tune override GPIO table
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/dedede/variants/drawcia/gpio.c:
https://review.coreboot.org/c/coreboot/+/51153/comment/87330732_e09a7208 
PS3, Line 28: board_version == 6 || board_version == 8
:(. I am guessing this is because of the no FW_CONFIG bit for pen support and inability to use external pull on the pen detect line?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I320de9a0c37ac033f3efda74eeb8f36e34667fd4
Gerrit-Change-Number: 51153
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Evan Green evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Henry Sun henrysun@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Henry Sun henrysun@google.com
Gerrit-Attention: Evan Green evgreen@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 01 Mar 2021 20:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment