Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )
Change subject: nb/intel/i945: Programm CxODT value for each channel
......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/#/c/18548/21/src/northbridge/intel/i945/raminit....
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/18548/21/src/northbridge/intel/i945/raminit....
PS21, Line 2460:
:
The logic is not the same as the new code. This condition is entered only if a dimm or both are not installed. IDK what the correct logic ought to be...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/18548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aec35f45250da554ddc5a68f5add157c313399c
Gerrit-Change-Number: 18548
Gerrit-PatchSet: 21
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sun, 24 Mar 2019 09:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment