Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Fred Reitberger.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55411 )
Change subject: amdfwtool: Change the name of macros for 'BHD'
......................................................................
Patch Set 27:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55411/comment/2cc47d8b_c2742128
PS27, Line 9: Use BHD instead of BDT as the name of cookie macro.
: Use L2 to make it clear it is for level 2. The 'BHD2' is misleading,
: which is going to be used for combo entry.
: The definition in psp_verstage is also changed.
Please mark it up as a list, or do not wrap lines just because a sentence ends.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55411
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia10ac5e873dab6db7d66e63773a7c63f504950b2
Gerrit-Change-Number: 55411
Gerrit-PatchSet: 27
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 15 Apr 2022 06:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment