Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49816 )
Change subject: soc/amd/picasso: Give FWM position index a default value
......................................................................
Patch Set 7:
(1 comment)
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/49816/comment/f3ff7af9_70e161f6
PS7, Line 364: default 4
this will probably hard-code AMD_FWM_POSITION_INDEX to 4 if the board doesn't override this setting. i'll try to have a closer look later
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib56a86fa70c50eff7144086730d2a4521af62a5a
Gerrit-Change-Number: 49816
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Fri, 22 Jan 2021 15:41:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment