Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62800 )
Change subject: soc/mediatek: PCI: Remove global variable
......................................................................
Patch Set 2:
(2 comments)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62800/comment/639cf93e_b0cb5435
PS1, Line 100: {
Let's cache 'base' (using static variable) inside this function.
Done
https://review.coreboot.org/c/coreboot/+/62800/comment/0b6ec078_4757ee34
PS1, Line 210: ctrl
conf
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia41c82a7aa5d6e9d936e242550851cef83afeae9
Gerrit-Change-Number: 62800
Gerrit-PatchSet: 2
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 06:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment