Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34673 )
Change subject: opencellular/rotundu: Disable HAVE_ACPI_RESUME support ......................................................................
opencellular/rotundu: Disable HAVE_ACPI_RESUME support
FSP1.0 has low memory corruptions below CONFIG_RAMTOP on S3 resume path, as romstage ram stack will be utilised before there is a chance to make the necessary backup to CBMEM.
Previously done for intel/minnowmax in commit b6fc727.
Change-Id: I2e128079b180f9978e8519b190648d516aaee0dc Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/opencellular/rotundu/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/34673/1
diff --git a/src/mainboard/opencellular/rotundu/Kconfig b/src/mainboard/opencellular/rotundu/Kconfig index fe1cbf9..ddacbe7 100644 --- a/src/mainboard/opencellular/rotundu/Kconfig +++ b/src/mainboard/opencellular/rotundu/Kconfig @@ -23,7 +23,6 @@ select HAVE_OPTION_TABLE select ENABLE_BUILTIN_COM1 select ENABLE_FSP_FAST_BOOT - select HAVE_ACPI_RESUME select USE_BLOBS select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT select MAINBOARD_HAS_LPC_TPM
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34673 )
Change subject: opencellular/rotundu: Disable HAVE_ACPI_RESUME support ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34673 )
Change subject: opencellular/rotundu: Disable HAVE_ACPI_RESUME support ......................................................................
opencellular/rotundu: Disable HAVE_ACPI_RESUME support
FSP1.0 has low memory corruptions below CONFIG_RAMTOP on S3 resume path, as romstage ram stack will be utilised before there is a chance to make the necessary backup to CBMEM.
Previously done for intel/minnowmax in commit b6fc727.
Change-Id: I2e128079b180f9978e8519b190648d516aaee0dc Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34673 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/opencellular/rotundu/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/opencellular/rotundu/Kconfig b/src/mainboard/opencellular/rotundu/Kconfig index fe1cbf9..ddacbe7 100644 --- a/src/mainboard/opencellular/rotundu/Kconfig +++ b/src/mainboard/opencellular/rotundu/Kconfig @@ -23,7 +23,6 @@ select HAVE_OPTION_TABLE select ENABLE_BUILTIN_COM1 select ENABLE_FSP_FAST_BOOT - select HAVE_ACPI_RESUME select USE_BLOBS select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT select MAINBOARD_HAS_LPC_TPM
-
Arthur Heymans (Code Review) -
Kyösti Mälkki (Code Review)