[M] Change in coreboot[main]: soc/intel/common/systemagent: Improve systemagent

[Arthur Heymans (Code Review)]

Attention is currently required from: Felix Held, Felix Singer, Jérémy Compostella, [e-mail].

Arthur Heymans has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83318?usp=email )

Change subject: soc/intel/common/systemagent: Improve systemagent
......................................................................

Patch Set 13:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83318/comment/b62145f8_fe3246e0?usp... :
PS13, Line 9: System agent in Intel common block (1) assumes TOLUD and TOUUD
            : registers hold the max available address plus 1, but on some SoC like
            : Snow Ridge, it holds the max available address; (2) aligns TOLUD, TOUUD
            : and TSEG registers to 1 MiB default, but some SoC may have different
            : alignments. This patch add a new weak function
            : `soc_systemagent_fixup_address()` to improve it.
Can you not capture the different semantics of the registers in Kconfig, have SOC select it and keep the common code? The weak callbacks make it less clear what is going on.