Attention is currently required from: Arthur Heymans, Kane Chen, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63553 )
Change subject: cpu/x86/mp_init.c: Add wait_finished_mp_run_on_all_cpus
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS3:
i tried this patch and the race condition is gone.
I also base on Arthur's patch to create another solution. not sure if you like it.
see https://review.coreboot.org/c/coreboot/+/63566
basically it adds a parameter wait_ap_complete in mp_callback and it can decide AP calls store_callback before or after lcb.func(lcb.arg)
It looks better indeed but I have to take a deeper look.
Patchset:
PS5:
Ow I pushed an older version here...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70244557bb384739e3bd06de3d8414ec9f4d5f62
Gerrit-Change-Number: 63553
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 07:29:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-MessageType: comment