Attention is currently required from: Paul Menzel, Rex-BC Chen, Angel Pons, Yu-Ping Wu, Jianjun Wang.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63020 )
Change subject: soc/mediatek/mt8195: Add early init support
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/cherry/bootblock.c:
https://review.coreboot.org/c/coreboot/+/63020/comment/32cfcdc1_ceba0e85
PS1, Line 49: mtk_clear_early_init();
Can we do this in bootblock_soc_init()?
agree, if bootblock_soc_init runs earlier than bootblock_mainboard_init then we should do it there
https://review.coreboot.org/c/coreboot/+/63020/comment/2c1a76a5_ff118c52
PS1, Line 51: if (CONFIG(PCI))
: mtk_pcie_pre_init();
shouldn't we do this only if MEDIATEK_EARLY_INIT is set?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63020
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4eb7da53ff76c385cab18bbf84970e96b61662ac
Gerrit-Change-Number: 63020
Gerrit-PatchSet: 1
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 24 Mar 2022 02:46:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment