Attention is currently required from: Anil Kumar K, Subrata Banik, Paul Menzel, Andrey Petrov, Patrick Rudolph. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59324 )
Change subject: [WIP] drivers/intel/fsp2_0: Add FSP 2.3 support ......................................................................
Patch Set 14:
(3 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/59324/comment/a32fbfc0_0c34b766 PS14, Line 38: Features added into FSP 2.3 specification that impact coreboot are: : 1. FSP_INFO_HEADER changes : Updated SpecVersion from 0x22 to 0x23 : Updated HeaderRevision from 5 to 6 : Added ExtendedImageRevision : FSP_INFO_HEADER length changed to 0x50 : 2. Added FSP_NON_VOLATILE_STORAGE_HOB2 I am not sure that this is a helpful text in the Kconfig menu. I would rather tend to keep it clean here and describe the changes in the commit.
File src/drivers/intel/fsp2_0/header_display.c:
https://review.coreboot.org/c/coreboot/+/59324/comment/2fce06f9_a26655c6 PS14, Line 11: externded extended
https://review.coreboot.org/c/coreboot/+/59324/comment/2c08f81c_76a05915 PS14, Line 22: ((ext_revision.rev.revision << 8) | revision.rev.revision), : ((ext_revision.rev.bld_num << 8) | revision.rev.bld_num)); You fill in the extended revision number only if FSP2.3 config swicth is set but print it here unconditionally. At least I would like to have some known init values for this field so that we do not have gibberish printed here for non FSP2.3 paths.