Attention is currently required from: Andy Hsu, Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85654?usp=email )
Change subject: soc/mediatek/mt8196: Add GPUEB support
......................................................................
Patch Set 3:
(3 comments)
File src/soc/mediatek/mt8196/gpueb.c:
https://review.coreboot.org/c/coreboot/+/85654/comment/941d76ac_fa51e1ad?usp... :
PS3, Line 20: BIOS_CRIT
BIOS_DEBUG
File src/soc/mediatek/mt8196/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/85654/comment/d2bbaa8e_265c6870?usp... :
PS3, Line 197: GPUEB_BASE
MFG_GPUEB_BASE
File src/soc/mediatek/mt8196/include/soc/gpueb_priv.h:
https://review.coreboot.org/c/coreboot/+/85654/comment/24b75c3c_133a597a?usp... :
PS2, Line 57: #define MFG_RPC_GHPM_CFG13_CON (GPU_EB_RPC_BASE + 0x0834) /* 0x4B800834 */
: #define MFG_GHPM_RO2_CON (MFG_RPC_BASE + 0x09AC) /* 0x4B8009AC */
The bases are the same. `MFG_RPC_BASE` should be removed here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f10dfc753f73df97ea08a4c23e97de416832be2
Gerrit-Change-Number: 85654
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Andy Hsu
andy.hsu@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 23 Dec 2024 10:20:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com