Change in coreboot[master]: cpu/x86/lapic: Unconditionally use CPUID leaf 0xb if available
Attention is currently required from: Wonkyu Kim, Tim Wawrzynczak, Angel Pons, Felix Held. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58386 ) Change subject: cpu/x86/lapic: Unconditionally use CPUID leaf 0xb if available ...................................................................... Patch Set 6: (2 comments) File src/cpu/x86/smm/smm_stub.S: https://review.coreboot.org/c/coreboot/+/58386/comment/0507d036_303a6fa0 PS4, Line 108: jc 1f
the carry flag and zero flag are set as if `%eax - $0xb` is performed, so if the highest leaf is < 0 […] Ack
https://review.coreboot.org/c/coreboot/+/58386/comment/6141b606_a1e2c523 PS4, Line 124: cmp (%ebx, %ecx, 2), %ax
This is an idea for a follow-up, right? Ack
-- To view, visit https://review.coreboot.org/c/coreboot/+/58386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f1f46fe5091ebeab6dfb4c7e151150cf495d0cb Gerrit-Change-Number: 58386 Gerrit-PatchSet: 6 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Wonkyu Kim <wonkyu.kim@intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Thu, 03 Feb 2022 18:16:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Kyösti Mälkki (Code Review)