Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46948 )
Change subject: mb/purism/librem_bdw: Use Haswell CPU code ......................................................................
mb/purism/librem_bdw: Use Haswell CPU code
Change-Id: I736bff90305952d279a10dfe90a2ee3a533220b5 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_bdw/Kconfig M src/mainboard/purism/librem_bdw/devicetree.cb 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/46948/1
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index 275594b..173874c 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -1,5 +1,6 @@ config BOARD_PURISM_BASEBOARD_LIBREM_BDW def_bool n + select CPU_INTEL_HASWELL select SYSTEM_TYPE_LAPTOP select BOARD_ROMSIZE_KB_8192 select HAVE_ACPI_RESUME diff --git a/src/mainboard/purism/librem_bdw/devicetree.cb b/src/mainboard/purism/librem_bdw/devicetree.cb index 0d0fc72..0575a98 100644 --- a/src/mainboard/purism/librem_bdw/devicetree.cb +++ b/src/mainboard/purism/librem_bdw/devicetree.cb @@ -17,7 +17,10 @@ register "gpu_panel_power_backlight_off_delay" = "2000" # 200ms
device cpu_cluster 0 on - device lapic 0 on end + chip cpu/intel/haswell + device lapic 0 on end + device lapic 0xacac off end + end end device domain 0 on device pci 00.0 on end # host bridge
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46948
to look at the new patch set (#5).
Change subject: mb/purism/librem_bdw: Use Haswell CPU code ......................................................................
mb/purism/librem_bdw: Use Haswell CPU code
Change-Id: I736bff90305952d279a10dfe90a2ee3a533220b5 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_bdw/Kconfig M src/mainboard/purism/librem_bdw/devicetree.cb 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/46948/5
Attention is currently required from: Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46948 )
Change subject: mb/purism/librem_bdw: Use Haswell CPU code ......................................................................
Patch Set 15: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46948 )
Change subject: mb/purism/librem_bdw: Use Haswell CPU code ......................................................................
mb/purism/librem_bdw: Use Haswell CPU code
Change-Id: I736bff90305952d279a10dfe90a2ee3a533220b5 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46948 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/purism/librem_bdw/Kconfig M src/mainboard/purism/librem_bdw/devicetree.cb 2 files changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index ad764b7..481909b 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -1,5 +1,6 @@ config BOARD_PURISM_BASEBOARD_LIBREM_BDW def_bool n + select CPU_INTEL_HASWELL select SYSTEM_TYPE_LAPTOP select BOARD_ROMSIZE_KB_8192 select HAVE_ACPI_RESUME diff --git a/src/mainboard/purism/librem_bdw/devicetree.cb b/src/mainboard/purism/librem_bdw/devicetree.cb index cd5bb44..9995f6b 100644 --- a/src/mainboard/purism/librem_bdw/devicetree.cb +++ b/src/mainboard/purism/librem_bdw/devicetree.cb @@ -16,7 +16,10 @@ }"
device cpu_cluster 0 on - device lapic 0 on end + chip cpu/intel/haswell + device lapic 0 on end + device lapic 0xacac off end + end end device domain 0 on device pci 00.0 on end # host bridge
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)