Attention is currently required from: Subrata Banik.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74562 )
Change subject: mb/google/rex: Enable asynchronous End-Of-Post
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/74562/comment/90ef9090_d9e10b6c
PS1, Line 92: if !BOARD_GOOGLE_REX_COMMON
Ack
that looks a bit better to me; might be good to see if it's possible to have a soc-defined default and being able to select an override in the mainboard kconfig.
since i'm not a maintainer of this subtree, i don't have a too strong opinion on this; just some suggestions about how i'd probably do this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74562
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27b540eeddcada521eba91fcc51504831d6dc855
Gerrit-Change-Number: 74562
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 20:17:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment