Change in coreboot[master]: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Felix Singer (Code Review)

7 Jan 2021 7 Jan '21

2:16 a.m.

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49192 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro ......................................................................

mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro

Macros should not use a trailing semicolon.

Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/hp/pavilion_m6_1035dx/mptable.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/49192/1

diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c index 7212c7d..e4c60d1 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c @@ -96,7 +96,7 @@

/* I/O Ints: Type Polarity Trigger Bus ID IRQ APIC ID PIN# */ #define IO_LOCAL_INT(type, intr, apicid, pin) \ - smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)); + smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) mptable_add_isa_interrupts(mc, bus_isa, ioapic_id, 0);

/* PCI interrupts are level triggered, and are

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

build bot (Jenkins) (Code Review)

7 Jan 7 Jan

2:24 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49192 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/49192/1/src/mainboard/hp/pavilion_m... File src/mainboard/hp/pavilion_m6_1035dx/mptable.c:

https://review.coreboot.org/c/coreboot/+/49192/1/src/mainboard/hp/pavilion_m... PS1, Line 99: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/49192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Gerrit-Change-Number: 49192 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 07 Jan 2021 02:24:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

8:39 p.m.

Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49192 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/49192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Gerrit-Change-Number: 49192 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 20:39:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

8 Jan 8 Jan

6:43 a.m.

Attention is currently required from: Felix Singer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49192 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro ......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/hp/pavilion_m6_1035dx/mptable.c:

https://review.coreboot.org/c/coreboot/+/49192/comment/1c774b21_aa04437a PS2, Line 99: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/49192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Gerrit-Change-Number: 49192 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Fri, 08 Jan 2021 06:43:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9:32 p.m.

Attention is currently required from: Felix Singer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49192 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro ......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/hp/pavilion_m6_1035dx/mptable.c:

https://review.coreboot.org/c/coreboot/+/49192/comment/47e74256_c006099c PS3, Line 99: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/49192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Gerrit-Change-Number: 49192 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Fri, 08 Jan 2021 21:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9 Jan 9 Jan

1:33 p.m.

Attention is currently required from: Felix Singer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49192 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro ......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/hp/pavilion_m6_1035dx/mptable.c:

https://review.coreboot.org/c/coreboot/+/49192/comment/d6e2992b_3c09874d PS4, Line 99: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/49192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Gerrit-Change-Number: 49192 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Sat, 09 Jan 2021 13:33:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Singer (Code Review)

3:10 p.m.

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49192

to look at the new patch set (#5).

Change subject: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro ......................................................................

mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro

Macros should not use a trailing semicolon.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/49192/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/49192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Gerrit-Change-Number: 49192 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

3:11 p.m.

Attention is currently required from: Felix Singer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49192 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro ......................................................................

Patch Set 5:

(1 comment)

File src/mainboard/hp/pavilion_m6_1035dx/mptable.c:

https://review.coreboot.org/c/coreboot/+/49192/comment/c2c88df2_9b23ac61 PS5, Line 99: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters

-- To view, visit https://review.coreboot.org/c/coreboot/+/49192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Gerrit-Change-Number: 49192 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Sat, 09 Jan 2021 15:11:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

3:19 p.m.

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49192 )

Change subject: mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro ......................................................................

mb/hp/pavilion_m6_1035dx: Remove trailing semicolon from macro

Macros should not use a trailing semicolon.

Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/49192 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/hp/pavilion_m6_1035dx/mptable.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

/* PCI interrupts are level triggered, and are

-- To view, visit https://review.coreboot.org/c/coreboot/+/49192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbcd589c7afa72e9e468e5f4b557bb2c665bbec0 Gerrit-Change-Number: 49192 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1224

days inactive

1226

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

build bot (Jenkins) (Code Review)
Felix Singer (Code Review)
Nico Huber (Code Review)