Attention is currently required from: Xuxin Xiong.
Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51004 )
Change subject: mb/google/trogdor: Add new configs homestar
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/51004/comment/e31b7bc0_4397b41e
PS9, Line 20: #define GPIO_EN_PP3300_DX_EDP (CONFIG(TROGDOR_REV0) ? GPIO(106) : \
: (CONFIG(BOARD_GOOGLE_COACHZ) && board_id() == 0 ? GPIO(52) : \
: (CONFIG(BOARD_GOOGLE_LAZOR) || CONFIG(BOARD_GOOGLE_POMPOM) ? GPIO(30) : \
: GPIO(67))))
Am I reading it right that trogdor-rev1 is broken here? For trogdors:
* trogdor-rev0: 106
* trogdor-rev1: 30
* trogdor-rev2: 67
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0f9b6c89198a882acae7191d08b166eb8c1dd71
Gerrit-Change-Number: 51004
Gerrit-PatchSet: 9
Gerrit-Owner: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Wai-Hong Tam
waihong@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Douglas Anderson
dianders@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 22:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment