Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Nick Vaccaro, Kyösti Mälkki.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61215 )
Change subject: device: Add support for PCIe Resizable BARs
......................................................................
Patch Set 2:
(1 comment)
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/61215/comment/2ade4eea_0afc30c0
PS2, Line 324: ctrl0
can we rename this to rebar_ctrl_reg or ctrl_reg.
When I read `reg` I assume it's describing the register, e.g. its offset,
and not its content.
Unable to understand why we have '0' here.
See comment above and loop below, it's the first of many such register
values and needs to be the first to work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14fcbe0ef09fdc7f6061bcf7439d1160d3bc4abf
Gerrit-Change-Number: 61215
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 27 Jan 2022 13:15:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment