Change in coreboot[master]: device: add Kconfig option to hide GOP initialization option
Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36348 )
Change subject: device: add Kconfig option to hide GOP initialization option ......................................................................
device: add Kconfig option to hide GOP initialization option
There are mainboards that do not have any graphics ports connected to the SoC. It would be senseless to initialize the iGD, thus add a new mainboard Kconfig to hide the GOP option.
Change-Id: Ica3b3a7a0c8120c95412369a24d8d669fb59fded Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/device/Kconfig 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/36348/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index 97ed997..a62eac8 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -36,6 +36,11 @@ Selected by drivers that support to run a blob that implements the Graphics Output Protocol (GOP).
+config MAINBOARD_NO_FSP_GOP + bool + help + Selected by mainboards that do not have any graphics ports connected to the SoC. + config MAINBOARD_HAS_NATIVE_VGA_INIT def_bool n help @@ -94,7 +99,7 @@
config RUN_FSP_GOP bool "Run a GOP driver" - depends on HAVE_FSP_GOP + depends on HAVE_FSP_GOP && !MAINBOARD_NO_FSP_GOP select HAVE_LINEAR_FRAMEBUFFER help Some platforms (e.g. Intel Braswell and Skylake/Kaby Lake) support
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36348 )
Change subject: device: add Kconfig option to hide GOP initialization option ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36348 )
Change subject: device: add Kconfig option to hide GOP initialization option ......................................................................
device: add Kconfig option to hide GOP initialization option
There are mainboards that do not have any graphics ports connected to the SoC. It would be senseless to initialize the iGD, thus add a new mainboard Kconfig to hide the GOP option.
Change-Id: Ica3b3a7a0c8120c95412369a24d8d669fb59fded Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/36348 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/device/Kconfig 1 file changed, 6 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/device/Kconfig b/src/device/Kconfig index 97ed997..a62eac8 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -36,6 +36,11 @@ Selected by drivers that support to run a blob that implements the Graphics Output Protocol (GOP).
+config MAINBOARD_NO_FSP_GOP + bool + help + Selected by mainboards that do not have any graphics ports connected to the SoC. + config MAINBOARD_HAS_NATIVE_VGA_INIT def_bool n help @@ -94,7 +99,7 @@
config RUN_FSP_GOP bool "Run a GOP driver" - depends on HAVE_FSP_GOP + depends on HAVE_FSP_GOP && !MAINBOARD_NO_FSP_GOP select HAVE_LINEAR_FRAMEBUFFER help Some platforms (e.g. Intel Braswell and Skylake/Kaby Lake) support
-
Martin Roth (Code Review) -
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)