Attention is currently required from: Jason Glenesk, Marshall Dawson, Tim Wawrzynczak, Nick Vaccaro, Karthik Ramasubramanian, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58899 )
Change subject: ChromeOS: Add DECLARE_x_CROS_GPIOS() ......................................................................
Patch Set 8:
(7 comments)
File src/mainboard/google/jecht/chromeos.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133435): https://review.coreboot.org/c/coreboot/+/58899/comment/b7e0ea48_105def37 PS8, Line 75: <<<<<<< HEAD spaces required around that '<' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133435): https://review.coreboot.org/c/coreboot/+/58899/comment/ea41a250_73a1f70d PS8, Line 88: ======= spaces required around that '==' (ctx:ExO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133435): https://review.coreboot.org/c/coreboot/+/58899/comment/ee58d508_b6194607 PS8, Line 88: ======= spaces required around that '==' (ctx:OxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133435): https://review.coreboot.org/c/coreboot/+/58899/comment/bd4c2910_ab0d5dcf PS8, Line 88: ======= spaces required around that '==' (ctx:OxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133435): https://review.coreboot.org/c/coreboot/+/58899/comment/26502a48_ce265721 PS8, Line 88: ======= spaces required around that '=' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133435): https://review.coreboot.org/c/coreboot/+/58899/comment/cd0aaa1d_21467584 PS8, Line 90: >>>>>>> ChromeOS: Add DECLARE_x_CROS_GPIOS() spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133435): https://review.coreboot.org/c/coreboot/+/58899/comment/ea9da97b_70fe31d8 PS8, Line 90: >>>>>>> ChromeOS: Add DECLARE_x_CROS_GPIOS() spaces required around that ':' (ctx:VxW)