Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63523 )
Change subject: superio/smsc/mec1308: Drop `_PRS` for static devices ......................................................................
superio/smsc/mec1308: Drop `_PRS` for static devices
The `_PRS` ACPI object is not needed for static (non-configurable) devices. For devices where `_CRS` always provides the same set of resource settings, drop the `_PRS` object. Note that every dropped `_PRS` object only provides one set of resource settings, which is identical to the resource settings provided by the `_CRS` object.
In addition, drop `IGNORE_IASL_MISSING_DEPENDENCY` from the two mainboards using the MEC1308 code, `samsung/{lumpy, stumpy}`.
Change-Id: I5d5cdc28c2cfaa5dfcffd656060b931208977386 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/superio/smsc/mec1308/acpi/superio.asl 3 files changed, 0 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/63523/1
diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index f9710e5..d0574bb 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -1,8 +1,5 @@ if BOARD_SAMSUNG_LUMPY
-config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select SYSTEM_TYPE_LAPTOP diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index 13b0eacbf..2a706b9 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -1,8 +1,5 @@ if BOARD_SAMSUNG_STUMPY
-config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl index f692323..117de96 100644 --- a/src/superio/smsc/mec1308/acpi/superio.asl +++ b/src/superio/smsc/mec1308/acpi/superio.asl @@ -101,11 +101,6 @@ { IO (Decode16, SIO_SPM1_IO0, SIO_SPM1_IO0, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SPM1_IO0, SIO_SPM1_IO0, 0x08, 0x08) - }) } #endif
@@ -122,11 +117,6 @@ { IO (Decode16, SIO_SEC1_IO0, SIO_SEC1_IO0, 0x04, 0x04) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SEC1_IO0, SIO_SEC1_IO0, 0x04, 0x04) - }) } #endif
@@ -143,11 +133,6 @@ { IO (Decode16, SIO_SEC2_IO0, SIO_SEC2_IO0, 0x04, 0x04) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SEC2_IO0, SIO_SEC2_IO0, 0x04, 0x04) - }) } #endif
@@ -165,12 +150,6 @@ IO (Decode16, SIO_SSP1_IO0, SIO_SSP1_IO0, 0x08, 0x08) IRQNoFlags () {SIO_SSP1_IRQ} }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SSP1_IO0, SIO_SSP1_IO0, 0x08, 0x08) - IRQNoFlags () {SIO_SSP1_IRQ} - }) } #endif
@@ -190,13 +169,6 @@ IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif
@@ -213,11 +185,6 @@ { IO (Decode16, SIO_SEC0_IO0, SIO_SEC0_IO0, 0x04, 0x04) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_SEC0_IO0, SIO_SEC0_IO0, 0x04, 0x04) - }) } #endif
@@ -235,11 +202,6 @@ { IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) - }) } #endif }