Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63250 )
Change subject: IASL: Correct warning message for IASL missing dependency ......................................................................
IASL: Correct warning message for IASL missing dependency
Warning for _SRS includes _SRS. Warning for _DIS includes must have _SRS twice.
Remove requirement _SRS for _SRS is present. Removed second _SRS for _DIS is present.
BUG=N/A TEST=Verify correct message on built of facebook FBG1701
Change-Id: I1be740354b159e931e41323aef14e160cc09af19 Signed-off-by: Frans Hendriks fhendriks@eltan.com´ Reviewed-on: https://review.coreboot.org/c/coreboot/+/63250 Reviewed-by: Erik van den Bogaert ebogaert@eltan.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Erik van den Bogaert: Looks good to me, but someone else must approve
diff --git a/Makefile.inc b/Makefile.inc index f746ef9..6b1c45c 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -277,8 +277,8 @@ build_complete:: printf "*** WARNING: The ASL code for this platform is incomplete. Please fix it. ***\n" printf "*** If _PRS is present, must have _CRS and _SRS ***\n" - printf "*** If _SRS is present, must have _PRS, _CRS, and _SRS ***\n" - printf "*** If _DIS is present, must have _SRS, _PRS, _CRS, and _SRS ***\n" + printf "*** If _SRS is present, must have _PRS and _CRS ***\n" + printf "*** If _DIS is present, must have _SRS, _PRS and _CRS ***\n" endif
IGNORED_IASL_WARNINGS = $(addprefix -vw , $(IASL_WARNINGS_LIST))