New patch to review for coreboot: 42f9ebe southbridge/dmp/vortex86ex: Incorrect usage of logical vs. bitwise 'and'

[Edward O'Callaghan]

Edward O'Callaghan ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6153

-gerrit

commit 42f9ebe9fcbd61f0081ce19410f3e08aabce8b2d
Author: Edward O'Callaghan 
Date:   Sat Jun 28 18:30:06 2014 +1000

southbridge/dmp/vortex86ex: Incorrect usage of logical vs. bitwise 'and'

We should be using a logical bitwise 'and' here with the LSB and CONFIG_
    boolean. Spotted by Clang.

Change-Id: I8f822fd2647f1912906064363dc452b25a0eecf9
    Signed-off-by: Edward O'Callaghan 
---
 src/southbridge/dmp/vortex86ex/southbridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/southbridge/dmp/vortex86ex/southbridge.c b/src/southbridge/dmp/vortex86ex/southbridge.c
index c9b10b6..e66d350 100644
--- a/src/southbridge/dmp/vortex86ex/southbridge.c
+++ b/src/southbridge/dmp/vortex86ex/southbridge.c
@@ -231,7 +231,7 @@ static void pci_routing_fixup(struct device *dev)
    	unsigned char irqs[4] = { OHCII_IRQ, EHCII_IRQ, 0, 0 };
    	pci_assign_irqs(0, 0xa, irqs);
    }
-	if (CONFIG_IDE_NATIVE_MODE && PIDE_IRQ) {
+	if (CONFIG_IDE_NATIVE_MODE & PIDE_IRQ) {
    	/* IDE in native mode, setup PCI IRQ. */
    	unsigned char irqs[4] = { PIDE_IRQ, 0, 0, 0 };
    	pci_assign_irqs(0, 0xc, irqs);