Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 7:
At the moment the fhd mod board requires 3.3V from a separate cable, which causes elevated power consumption especially when the lid is closed or the machine is sleeping.
This is because the tapped source is always on.
Though if it was possible to provide power through the VCC3P power rail instead, the board could be supplied with power only when the display is supposed to be on. This would eliminate the extra cable and only requires that J1 jumper is closed on the board. I tried it myself and also measured a the corresponding pad but there seems to be no voltage present from the lvds connector with the current state of this patch.
Maybe someone more knowledgeable has an idea on how to implement this?
Did you also measure the voltage when Linux has booted?
I would assume that it works in Linux. If that is the
case, all that is left (as mentioned before) is to make
libgfxinit aware of the panel at the DP connector (needs
some restructuring, though).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 7
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Holger Levsen
holger@layer-acht.org
Gerrit-CC: Kilian Neuner
cb@9-r.net
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-Comment-Date: Sun, 24 Mar 2019 13:13:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment