Attention is currently required from: Angel Pons, Arthur Heymans, Felix Singer, Jincheng Li, Lean Sheng Tan, Patrick Rudolph.
Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/83328?usp=email )
Change subject: mb/intel/avenuecity_crb: Update SMBIOS info for type 0,1,2,3 ......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/intel/avenuecity_crb/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83328/comment/c4e8aa20_3f1e0565?usp... : PS5, Line 12: const char *smbios_mainboard_bios_version(void) : { : return "UNKNOWN"; : }
Default if unset is the coreboot version, which IMHO is more useful than "UNKNOWN": https://github. […]
Done
https://review.coreboot.org/c/coreboot/+/83328/comment/d161a649_54646796?usp... : PS5, Line 24: return "UNKNOWN";
Most of these default to empty strings. Will this code be changed in the future (e.g. […]
smbios_defaults.c definitely helps a lot! Applied the same updates as indicated in https://review.coreboot.org/c/coreboot/+/83327.
https://review.coreboot.org/c/coreboot/+/83328/comment/169a4873_66c09e34?usp... : PS5, Line 52: u8 smbios_chassis_power_cords(void) : { : return 1; : }
Same as default, can be omitted: https://github. […]
Done