Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84410?usp=email )
Change subject: soc/intel/ptl: Add GPE1 support in pmutil.c
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/pantherlake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/84410/comment/ca204ded_2f288139?usp... :
PS2, Line 181: if (std_gpe0_mask & PME_B0_EN)
: pmc_disable_gpe1(GPE1_EN(0), GPE1_PME_B0_EVENT_EN_BITS);
:
: if (std_gpe0_mask & TC_PME_B0_EN)
: pmc_disable_gpe1(GPE1_EN(0), GPE1_TC_PME_B0_EVENT_EN_BITS);
:
isn't `PME_B0_EN` is a super set of `TC_PME_B0_EN`?
No. TC_PME_B0_EN is added to GPE0 in PTL. TCSS uses separate one now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84410?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia79c49d399eff4b2f6978323b2f5e2bb167d8638
Gerrit-Change-Number: 84410
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 18 Sep 2024 03:16:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com