Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63518 )
Change subject: soc/intel/cmn/lockdown: Perform SA lockdown configuration
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
SOC_INTEL_COMMON_PCH_BASE also includes icelake, skylake and xeon_xp, would be good to note that this enforces SA lockdown config for those as well
Sure, it's enforcing ICL and SKL but Xeon_xp doesn't select `SOC_INTEL_COMMON_BLOCK_SA` Kconfig hence, added check to avoid compilation issue https://review.coreboot.org/c/coreboot/+/63518/11/src/soc/intel/common/pch/l...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd464d2507393ed0c746eb1fbd10e36092ed5599
Gerrit-Change-Number: 63518
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 22 Apr 2022 16:09:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment