Attention is currently required from: Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63555 )
Change subject: cpu/x86/mtrr.c: Allow for multiple TEMP MTRR ranges
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
is there a good reason why we use these temporary MTRR ranges to cover the ROM? Why don't we just add the ROM into the global MTRR solution as an uncachable type? POC: https://review.coreboot.org/c/coreboot/+/63557
Generally you want firmware out of the way when the payload is loaded. The payload generally also does not needed ROM access so to minimize MTRR usage it's best not to cache it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63555
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23442bd2ab7602e4c5cbd37d187a31413cf27ecc
Gerrit-Change-Number: 63555
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 11 Apr 2022 20:06:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment