Attention is currently required from: Matt DeVillier, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58188 )
Change subject: nb/sandybridge:add CBMEM_MEMINFO table when initing RAM ......................................................................
Patch Set 1:
(11 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58188/comment/f5221363_e9df9dad PS1, Line 7: nb/sandybridge:add CBMEM_MEMINFO table when initing RAM How about:
nb/intel/sandybridge: Populate meminfo when using MRC
https://review.coreboot.org/c/coreboot/+/58188/comment/b310668a_ce6ad86a PS1, Line 17: remove one space
File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/c/coreboot/+/58188/comment/700291aa_d2c32b52 PS1, Line 392: struct memory_info* mem_info;
"foo* bar" should be "foo *bar"
Please fix.
https://review.coreboot.org/c/coreboot/+/58188/comment/69c453c1_6dbf50f4 PS1, Line 406: / please add spaces around `/`. Or even better, use `DIV_ROUND_CLOSEST`.
https://review.coreboot.org/c/coreboot/+/58188/comment/4673db9b_8008f4dd PS1, Line 406: ddr_frequency See raminit_shared.c on how to calculate this, the reference clock can be 133 MHz or 100 MHz.
https://review.coreboot.org/c/coreboot/+/58188/comment/3970aadb_f87577e2 PS1, Line 411: // DIMM-A I'd much prefer C-style comments, for consistency with the rest of the file.
https://review.coreboot.org/c/coreboot/+/58188/comment/22d503ce_19aa9415 PS1, Line 422: memcpy(dimm->serial, // bytes 122-125 in SPD
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/58188/comment/8cf843b5_4138dbf1 PS1, Line 428: dimm->mod_id = // bytes 117/118 (LSB/MSB)
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/58188/comment/001bfefa_82c4be01 PS1, Line 446: memcpy(dimm->serial, // bytes 122-125 in SPD
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/58188/comment/200b4332_5302c874 PS1, Line 452: dimm->mod_id = // bytes 117/118 (LSB/MSB)
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/58188/comment/1e9ec44a_3be28908 PS1, Line 452: dimm->mod_id = // bytes 117/118 (LSB/MSB)
line over 96 characters
Please fix.