[L] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6373 driver - coreboot-gerrit

12 Dec 2024


      Attention is currently required from: Hope Wang, Hung-Te Lin, Yidi Lin.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85129?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6373 driver
......................................................................
Patch Set 35:
(1 comment)
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/85129/comment/99b4c1a4_6080a571?usp... :
PS29, Line 34: romstage-y += ../common/mt6373.c mt6373.c
...
Please explain why it is needed in romstage and ramstage.
romstage is for mt6373 init.
ramstage is for SD card.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85129?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icbcd1f5a22388093781fd92c31889dd55a0ed9a3
Gerrit-Change-Number: 85129
Gerrit-PatchSet: 35
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Hope Wang hope.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Thu, 12 Dec 2024 02:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin yidilin@google.com