[M] Change in coreboot[master]: soc/intel/cmd/blk/cse: Store fw versions in CMOS memory for cold boot

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75755?usp=email )

Change subject: soc/intel/cmd/blk/cse: Store fw versions in CMOS memory for cold boot
......................................................................

Patch Set 9:

(7 comments)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/75755/comment/f52f7cc2_19f37272 :
PS9, Line 137: static bool is_cse_fw_updated, is_cold_boot;
use a structure with two member variable (if needed)

https://review.coreboot.org/c/coreboot/+/75755/comment/e3a6d9a9_0d08b6bf :
PS9, Line 1205: 		/* cse has been updated*/
space?

https://review.coreboot.org/c/coreboot/+/75755/comment/b3e14381_e0956ca2 :
PS9, Line 1207: 		/* write cse rw fw version to CMOS and CBMEM */
```
/* write cse rw fw version to CMOS */
set_cmos_cse_rw_fw_version(&(cse_bp->fw_ver));
/* write cse rw fw version to CBMEM */
memcpy(&(version->cur_cse_fw_version), &(cse_bp->fw_ver), size);
```

https://review.coreboot.org/c/coreboot/+/75755/comment/ad460203_020e189c :
PS9, Line 1211: /* Current running CSE version is same as previous stored CSE version */
```
/* Check if current running CSE version is same as previous stored CSE version aka CBMEM region is still valid */
```

https://review.coreboot.org/c/coreboot/+/75755/comment/53496c0c_e0a7b1f8 :
PS9, Line 1218: memcpy(&(version->cur_cse_fw_version), &(cse_bp->fw_ver), size);
can we do something like this at line#1220 (outside loop) and drop this line here and from 1209 as well?

```
if (is_cold_boot || is_cse_fw_updated)
   memcpy(&(version->cur_cse_fw_version), &(cse_bp->fw_ver), size);
```

https://review.coreboot.org/c/coreboot/+/75755/comment/60e539cc_efe0ce13 :
PS9, Line 1306: 			set_cmos_ish_version(&(resp.manifest_data.version));
              : 			memcpy(&(version->ish_partition_info.cur_ish_fw_version),
              : 				&(resp.manifest_data.version), size);
```
/* write ISH rw fw version to CMOS */
set_cmos_ish_version(&(resp.manifest_data.version));
/* write ISH rw fw version to CBMEM */
memcpy(&(version->ish_partition_info.cur_ish_fw_version),
    			&(resp.manifest_data.version), size);
```

https://review.coreboot.org/c/coreboot/+/75755/comment/59a2a190_33106cf7 :
PS9, Line 1311: /*
              : 		 * The CBMEM was reset during cold reboot, so the ISH version in CBMEM
              : 		 * needs to be updated to the version stored in CMOS.
              : 		 */
```
        /*
    	 * The CBMEM was reset during cold reboot, so the ISH version in CBMEM
    	 * needs to be updated based on CMOS entry.
    	 */
```