Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Chris Wang, Martin Roth, Karthik Ramasubramanian, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71562 )
Change subject: soc/amd/mendocino: Hook up UPD dxio_tx_vboost_enable for PCIe optimization
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/mendocino/chip.h:
https://review.coreboot.org/c/coreboot/+/71562/comment/f7965ca2_fda4d953
PS2, Line 167: w/a
Because it's a workaround of an issue we were seeing. It's not a fix.
Then please summarize the problem in the comment or commit message.
https://review.coreboot.org/c/coreboot/+/71562/comment/5ec47fa7_b8287c32
PS2, Line 168: dxio_tx_vboost_enable
coreboot/src% grep -ir "_enable" | grep -v vendorcode | wc -l […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71562
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05ae5b3091219e0cb1fe469c929fad6a725db678
Gerrit-Change-Number: 71562
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 03 Jan 2023 19:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment