Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35907 )
Change subject: mb/google/hatch/variants/helios: Modify touchscreen power on sequence
......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 5:
Patch Set 3:
Patch Set 2:
Patch Set 2:
Patch Set 2:
(1 comment)
We add some time buffer to avoid margin case .
Were you seeing failures with the previous values?
The previous values do not affect the touchscreen function. But, the previous values cause the power leakage in S0ix.
Why does the previous setting cause power leakage? Can you please attach details to partner bug? Also, what is the margin required for? Do you notice the timing is not sufficient on the scope?
Please refer to partner bug(142368161) comment #4 for more detail.
Please see partner bug for latest comments. I have asked some more clarifying questions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35907
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86c920ff1d5c0b510adde8a37f60003072d5f4e7
Gerrit-Change-Number: 35907
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Assignee: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 21 Oct 2019 18:11:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment