Attention is currently required from: Benjamin Doron, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50050 )
Change subject: soc/intel/skylake: Move L1_substates_control to pcie_rp.h
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
Should the config name be reverted to match the UPD (PcieRpL1Substates) for consistency with other p […]
Did anything change, though. My strongest argument was that if it uses
different values, it should have a different name. If that still applies,
I'd rather update the other platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50050
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaafc507624151ec871ffcc0fba6da02b012cd038
Gerrit-Change-Number: 50050
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 04 Feb 2021 21:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment