Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )
Change subject: cpu/qemu-x86: Add x86_64 bootblock support ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35680/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35680/2//COMMIT_MSG@15 PS2, Line 15: Introduce a new tool called pgtblgen that creates x86 long mode compatible : page tables and writes those to a file. There already is util/x86/x86_page_tables for 32-bit PAE page tables. Would extending that to support 64bit be an option? I have not really looked at either one at this point to make a valid statement on this.
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/qemu-x86/cache_as_r... File src/cpu/qemu-x86/cache_as_ram_bootblock.S:
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/qemu-x86/cache_as_r... PS2, Line 42: #include <cpu/x86/64bit/entry64.inc> Should this happen in this mainboard specific file?
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/x86/64bit/entry64.i... File src/cpu/x86/64bit/entry64.inc:
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/x86/64bit/entry64.i... PS2, Line 25: $(CONFIG_ARCH_X86_64_PGTBL_LOC) Would it not be better to use some linker script magic and link the page tables in the bootblock and point to that symbol here?
https://review.coreboot.org/c/coreboot/+/35680/2/util/pgtblgen/pgtblgen.c File util/pgtblgen/pgtblgen.c:
https://review.coreboot.org/c/coreboot/+/35680/2/util/pgtblgen/pgtblgen.c@2 PS2, Line 2: msrtool update
-
Arthur Heymans (Code Review)