Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Poornima Tom, Subrata Banik.
Hello Poornima Tom,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/83148?usp=email
to review the following change.
Change subject: mb/google/nissa/var/nivviks: Disable CNVi Bluetooth based on fw_config ......................................................................
mb/google/nissa/var/nivviks: Disable CNVi Bluetooth based on fw_config
When PCIe based Wifi7 is enabled, CNVi based Bluetooth must be turned off, based on fw_config. Otherwise, when device boots with cbi settings for Wifi7, boot may fail with assertion error for line 817 & 819 of file 'src/soc/intel/alderlake/fsp_params.c'.
BUG=b:345596420 BRANCH=NONE TEST=Dut boots fine with both Wifi6 & Wifi7 based cbi settings, along with enumeration of corresponding BT device.
Change-Id: I03fde02fa4b36f4e47d6f0e95675feddb3bee7cd Signed-off-by: Poornima Tom poornima.tom@intel.corp-partner.google.com --- M src/mainboard/google/brya/variants/nivviks/fw_config.c 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/83148/1
diff --git a/src/mainboard/google/brya/variants/nivviks/fw_config.c b/src/mainboard/google/brya/variants/nivviks/fw_config.c index 5f00892..b0eb875 100644 --- a/src/mainboard/google/brya/variants/nivviks/fw_config.c +++ b/src/mainboard/google/brya/variants/nivviks/fw_config.c @@ -110,6 +110,16 @@ PAD_NC_LOCK(GPP_F15, NONE, LOCK_CONFIG), };
+void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config) +{ + if (fw_config_probe(FW_CONFIG(WIFI_CATEGORY, WIFI_7))) { + printk(BIOS_INFO, "CNVi bluetooth disabled by fw_config\n"); + config->cnvi_bt_core = false; + printk(BIOS_INFO, "CNVi bluetooth audio offload disabled by fw_config\n"); + config->cnvi_bt_audio_offload = false; + } +} + void fw_config_gpio_padbased_override(struct pad_config *padbased_table) { if (!fw_config_probe(FW_CONFIG(DB_USB, DB_1C_LTE))) {