Change in coreboot[master]: mb/google/zork: update stapm parameter for berknip

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kevin Chiu (Code Review)

28 Jul 2020 28 Jul '20

2:34 p.m.

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43997 )

Change subject: mb/google/zork: update stapm parameter for berknip ......................................................................

mb/google/zork: update stapm parameter for berknip

sustained_power_limit = 12w fast_ppt_limit = 24w slow_ppt_limit = 20w

BUG=none BRANCH=master TEST=emerge-zork coreboot chromeos-bootimage

Change-Id: I9baf9990e26edbbadfba85bc16b380c46684033d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/43997/1

diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index 31bf643..d250311 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -9,11 +9,11 @@ register "system_config" = "3"

# Set STAPM confiuration. All of these fields must be set >0 to take affect - register "slow_ppt_limit" = "25000" #mw - register "fast_ppt_limit" = "30000" #mw + register "slow_ppt_limit" = "20000" #mw + register "fast_ppt_limit" = "24000" #mw register "slow_ppt_time_constant" = "5" #second register "stapm_time_constant" = "200" #second - register "sustained_power_limit" = "25000" #mw + register "sustained_power_limit" = "12000" #mw

Attachments:

attachment.htm (text/html — 3.4 KB)

Show replies by date

Aaron Durbin (Code Review)

28 Jul 28 Jul

6:47 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43997 )

Change subject: mb/google/zork: update stapm parameter for berknip ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9baf9990e26edbbadfba85bc16b380c46684033d Gerrit-Change-Number: 43997 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 28 Jul 2020 16:47:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:52 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43997 )

Change subject: mb/google/zork: update stapm parameter for berknip ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43997/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43997/1//COMMIT_MSG@13 PS1, Line 13: none Is there a partner issue where you have captured the details of how/why the above values where determined/chosen?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9baf9990e26edbbadfba85bc16b380c46684033d Gerrit-Change-Number: 43997 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 28 Jul 2020 18:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

29 Jul 29 Jul

9:37 a.m.

Hello Kevin Chiu, build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43997

to look at the new patch set (#2).

Change subject: mb/google/zork: update stapm parameter for berknip ......................................................................

mb/google/zork: update stapm parameter for berknip

sustained_power_limit = 12w fast_ppt_limit = 24w slow_ppt_limit = 20w

BUG=b:162377903 BRANCH=master TEST=emerge-zork coreboot chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/43997/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9baf9990e26edbbadfba85bc16b380c46684033d Gerrit-Change-Number: 43997 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kevin Chiu kevin.chiu@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kevin Chiu (Code Review)

9:41 a.m.

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43997 )

Change subject: mb/google/zork: update stapm parameter for berknip ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43997/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43997/1//COMMIT_MSG@13 PS1, Line 13: none

...

Is there a partner issue where you have captured the details of how/why the above values where deter […]

Hi Furquan, update tracker: https://partnerissuetracker.corp.google.com/issues/162377903 thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9baf9990e26edbbadfba85bc16b380c46684033d Gerrit-Change-Number: 43997 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kevin Chiu kevin.chiu@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 29 Jul 2020 07:41:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Aaron Durbin (Code Review)

4:43 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43997 )

Change subject: mb/google/zork: update stapm parameter for berknip ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9baf9990e26edbbadfba85bc16b380c46684033d Gerrit-Change-Number: 43997 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kevin Chiu kevin.chiu@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 29 Jul 2020 14:43:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

4:43 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43997 )

Change subject: mb/google/zork: update stapm parameter for berknip ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43997/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43997/1//COMMIT_MSG@13 PS1, Line 13: none

...

Hi Furquan, […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9baf9990e26edbbadfba85bc16b380c46684033d Gerrit-Change-Number: 43997 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kevin Chiu kevin.chiu@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 29 Jul 2020 14:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu Kevin.Chiu@quantatw.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Aaron Durbin (Code Review)

4:43 p.m.

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43997 )

Change subject: mb/google/zork: update stapm parameter for berknip ......................................................................

mb/google/zork: update stapm parameter for berknip

sustained_power_limit = 12w fast_ppt_limit = 24w slow_ppt_limit = 20w

BUG=b:162377903 BRANCH=master TEST=emerge-zork coreboot chromeos-bootimage

Change-Id: I9baf9990e26edbbadfba85bc16b380c46684033d Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43997 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/43997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9baf9990e26edbbadfba85bc16b380c46684033d Gerrit-Change-Number: 43997 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kevin Chiu kevin.chiu@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1563

days inactive

1564

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

Aaron Durbin (Code Review)
Furquan Shaikh (Code Review)
Kevin Chiu (Code Review)