Attention is currently required from: Eran Mitrani, Kapil Porwal, Martin L Roth, Paul Menzel, Subrata Banik, Tarun, Tarun Tuli.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76796?usp=email )
Change subject: soc/intel/meteorlake: Add PsysPmax configuration
......................................................................
Patch Set 10:
(2 comments)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/76796/comment/2b83d82a_a61fedae :
PS10, Line 450: /* Platform Power Pmax in Watts */
Add comment about 0 being automatic?
Done
https://review.coreboot.org/c/coreboot/+/76796/comment/db461139_3f4dbdf1 :
PS10, Line 451: psys_pmax
Maybe change to psys_pmax_watts? Then the unit is obvious in devicetree.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76796?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69afa06110254f6384352c062891c0c9c0b23070
Gerrit-Change-Number: 76796
Gerrit-PatchSet: 10
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 28 Sep 2023 13:59:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment