Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76178?usp=email )
Change subject: acpi.c: Guard FACS generation ......................................................................
acpi.c: Guard FACS generation
It's not expected that non-x86 arch implement x86 style sleep states and resume.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: I7a1f36616e7f6adb021625e62e0fdf81864c7ac3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76178 Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Reviewed-by: Sridhar Siricilla sridhar.siricilla@intel.com Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/acpi/acpi.c 1 file changed, 8 insertions(+), 7 deletions(-)
Approvals: Sridhar Siricilla: Looks good to me, approved build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Eric Lai: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index dfa91e0..0bb49f6 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1499,13 +1499,14 @@ acpi_write_rsdt(rsdt, oem_id, oem_table_id); acpi_write_xsdt(xsdt, oem_id, oem_table_id);
- current = ALIGN_UP(current, 64); - - printk(BIOS_DEBUG, "ACPI: * FACS\n"); - facs = (acpi_facs_t *)current; - current += sizeof(acpi_facs_t); - current = acpi_align_current(current); - acpi_create_facs(facs); + if (ENV_X86) { + printk(BIOS_DEBUG, "ACPI: * FACS\n"); + current = ALIGN_UP(current, 64); + facs = (acpi_facs_t *)current; + current += sizeof(acpi_facs_t); + current = acpi_align_current(current); + acpi_create_facs(facs); + }
for (size_t i = 0; i < ARRAY_SIZE(tables); i++) { acpi_header_t *header = (acpi_header_t *)current;