Attention is currently required from: Jeff Daly, Mariusz Szafrański, Jonathan Zhang, Angel Pons, Eric Lai, Andrey Petrov, Anjaneya "Reddy" Chagam, Johnny Lin, Tim Wawrzynczak, Christian Walter, Suresh Bellampalli, Vanessa Eusebio, Werner Zeh, Tim Chu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64806 )
Change subject: soc/intel/common/cpu: Use SoC overrides to set CPU privilege level
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/skylake/cpu.c:
https://review.coreboot.org/c/coreboot/+/64806/comment/5fe465de_66588613
PS3, Line 40: if (!CONFIG(MAINBOARD_SUPPORTS_COFFEELAKE_CPU))
: return;
:
: msr_t msr;
:
: msr = rdmsr(MSR_BIOS_DONE);
: msr.lo |= ENABLE_IA_UNTRUSTED;
: wrmsr(MSR_BIOS_DONE, msr);
I guess this would need runtime detection to do right (skylake in a coffeelake board if that is even […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64806
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4584516102560e6bb2a4ae8c0d036be40ed96990
Gerrit-Change-Number: 64806
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 31 May 2022 16:25:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment