[S] Change in coreboot[main]: soc/mt6366: Work around GCC LTO build

[Julius Werner (Code Review)]

Attention is currently required from: Arthur Heymans, Cliff Huang, Elyes Haouas, Hung-Te Lin, Jérémy Compostella, Lance Zhao, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu.

Julius Werner has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84208?usp=email )

Change subject: soc/mt6366: Work around GCC LTO build
......................................................................

Patch Set 8:

(3 comments)

Patchset:

PS5:
> could you please report to gcc if it hasn't already been done?

+1, have you tried to isolate this and report it to GCC?

File src/soc/mediatek/mt8186/mt6366.c:

https://review.coreboot.org/c/coreboot/+/84208/comment/52e1961c_3b2b50d0?usp... :
PS8, Line 10: #define NO_BUILDTIME_ASSERT
It looks like this is only a problem with very specific assert statements, so if we do want to hack around it (which generally doesn't sit that well with me, but I guess as long as it's only this one file that's okay (though somewhat odd)), shouldn't we rather add new macros that only disable it for that specific statement rather than for a whole file at a time (e.g. ASSERT_LTO_WORKAROUND(...))?

File src/vendorcode/amd/pi/00670F00/Porting.h:

https://review.coreboot.org/c/coreboot/+/84208/comment/c1db0ad4_0959c29b?usp... :
PS8, Line 47: _PORTING_H_
Isn't this a header guard? I think you should leave it in place and just define NO_BUILDTIME_ASSERT in addition to it.